Skip to content

[release-4.20] OCPBUGS-65761: Preserve query string in perspective switch + remove dev console folks from reviewers #15740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 24, 2025
Merged

[release-4.20] OCPBUGS-65761: Preserve query string in perspective switch + remove dev console folks from reviewers #15740

merged 3 commits into from
Nov 24, 2025

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Nov 19, 2025 •
edited
Loading

This is an automated cherry-pick of #15736

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 19, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 19, 2025

@logonoff: This pull request references Jira Issue OCPBUGS-65761, which is invalid:

  • expected dependent Jira Issue OCPBUGS-65696 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/topology Related to topology labels Nov 19, 2025
@logonoff
Copy link
Member Author

logonoff commented Nov 20, 2025

/assign @yapei

@logonoff logonoff force-pushed the OCPBUGS-65761-release-4.20-preserve-search branch from 7ab8ad1 to fd86b9c Compare November 20, 2025 13:33
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yapei
Copy link
Contributor

yapei commented Nov 24, 2025

sub path and query params can be preserved when switching perspective
https://github.com/user-attachments/assets/a68e3c61-7ae1-45ce-b572-310851b78e4d

/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 24, 2025

@yapei: This PR has been marked as verified by @yapei.

In response to this:

sub path and query params can be preserved when switching perspective
https://github.com/user-attachments/assets/a68e3c61-7ae1-45ce-b572-310851b78e4d

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

logonoff commented Nov 24, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 24, 2025

@logonoff: This pull request references Jira Issue OCPBUGS-65761, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-65696 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-65696 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei November 24, 2025 13:41
@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Nov 24, 2025

Thanks for removing me 😅👍

/uncc

@openshift-ci openshift-ci bot removed the request for review from christoph-jerolimov November 24, 2025 14:08
jhadvig
jhadvig approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 24, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e27f8d1 into openshift:release-4.20 Nov 24, 2025
8 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 24, 2025

@logonoff: Jira Issue Verification Checks: Jira Issue OCPBUGS-65761
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-65761 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This is an automated cherry-pick of #15736

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff deleted the OCPBUGS-65761-release-4.20-preserve-search branch November 24, 2025 14:32
@logonoff
Copy link
Member Author

logonoff commented Nov 24, 2025

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 24, 2025

@logonoff: #15740 failed to apply on top of branch "release-4.19":

Applying: OCPBUGS-65761: Preserve query string in perspective switch
Using index info to reconstruct a base tree...
M	frontend/packages/console-app/src/components/detect-perspective/DetectPerspective.tsx
M	frontend/packages/console-app/src/components/detect-perspective/PerspectiveDetector.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/console-app/src/components/detect-perspective/PerspectiveDetector.tsx
CONFLICT (content): Merge conflict in frontend/packages/console-app/src/components/detect-perspective/PerspectiveDetector.tsx
Auto-merging frontend/packages/console-app/src/components/detect-perspective/DetectPerspective.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-65761: Preserve query string in perspective switch

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@logonoff logonoff mentioned this pull request Nov 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@yapei yapei Awaiting requested review from yapei

Assignees

@jhadvig jhadvig

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

@XiyunZhao XiyunZhao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/topology Related to topology jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@logonoff @openshift-ci-robot @yapei @christoph-jerolimov @openshift-cherrypick-robot @jhadvig @yanpzhan @sanketpathak @XiyunZhao